Fixes for prepared statements and literal values #1406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Contributor
Footnotes
|
Hydrocharged
approved these changes
Apr 21, 2025
| // Value returns the literal value. | ||
| func (l *Literal) Value() any { | ||
| // LiteralValue implements the sql.LiteralExpression interface | ||
| func (l *Literal) LiteralValue() interface{} { |
Collaborator
There was a problem hiding this comment.
I remember way back you mentioned that we should abandon interface{} and use any now, but I've noticed you using interface{} for a few PRs now. Should we go back to interface{}?
Member
Author
|
Superseded by #1437 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues when using bindvars in a couple different places in certain queries. It introduces a new LiteralExpression so that it GMS and Doltgres implementations of literal values can be used interchangeably during planning and analysis.
Relies on dolthub/go-mysql-server#2946